patheard commented on code in PR #31173:
URL: https://github.com/apache/superset/pull/31173#discussion_r1860900304
##########
superset/tasks/utils.py:
##########
@@ -133,7 +133,7 @@ def fetch_csrf_token(
data = json.loads(body)
res = {"X-CSRF-Token": data["result"]}
if session_cookie is not None:
- res["Cookie"] = session_cookie
+ res["Cookie"] = f"session={session_cookie}"
Review Comment:
Good timing, I just stumbled on this bug yesterday in 4.1.1. One minor
tweak though - could you use the `session_cookie_name` param like so?
```suggestion
res["Cookie"] = f"{session_cookie_name}={session_cookie}"
```
In my local testing it worked as expected since it defaults to `session`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
