mistercrunch commented on code in PR #31173:
URL: https://github.com/apache/superset/pull/31173#discussion_r1872087726


##########
superset/tasks/utils.py:
##########
@@ -133,7 +133,7 @@ def fetch_csrf_token(
             data = json.loads(body)
             res = {"X-CSRF-Token": data["result"]}
             if session_cookie is not None:
-                res["Cookie"] = session_cookie
+                res["Cookie"] = f"{session_cookie_name}={session_cookie}"

Review Comment:
   Thanks for running the extra tests. I'm just wondering how it works now for 
some people without specifying the cookie name as you do here. If it works now 
for them, how would changing what works with a name prefix not break things (?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to