nsivarajan commented on code in PR #31173:
URL: https://github.com/apache/superset/pull/31173#discussion_r1872826481
##########
superset/tasks/utils.py:
##########
@@ -133,7 +133,7 @@ def fetch_csrf_token(
data = json.loads(body)
res = {"X-CSRF-Token": data["result"]}
if session_cookie is not None:
- res["Cookie"] = session_cookie
+ res["Cookie"] = f"{session_cookie_name}={session_cookie}"
Review Comment:
I agree that there may be edge cases or environments where this adjustment
could impact behavior. I will add a note to `UPDATING.md` as you suggested,
explaining the change and advising users to report any CSRF-related issues
while referencing PR #31173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
