rusackas commented on PR #31037: URL: https://github.com/apache/superset/pull/31037#issuecomment-2530438814
Hi! Sorry. Just a bit swamped... I'll have to get back to it soon. Ideally, the Jupyter notebook would make the same edits you're doing by hand... then Natural Earth can update their source data, and modifications are applied. Pulling the data from an externally hosted json file is kind of a workaround, but we lose the benefit of having a maintained upstream data provider... that geojson is likely going to be static forever. We probably shouldn't have let that happen with India, honestly. If you look at how the notebook was pulling in the other islands for France, we should do the same with any other islands that weren't already included. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
