tarraschk commented on PR #31037: URL: https://github.com/apache/superset/pull/31037#issuecomment-2546147542
After discussions with @rusackas here are some additional considerations. The old map for France is actually the one with only French departments, including islands that are considered as departments My map in this PR is the map of departments, plus the French additional territories that have their autonomy and that are not included as departments regarding administrative authorities. As is, this PR adds a 3rd map for France which might be considered as "la lot" of maps for only one country! I think we have two options: Option A: we add my map as a third map of France - Benefits: nothing changes for actual Superset users that use the existing France map (departments or regions) - Bad side: it adds a third map of France, which could be considered like a lot for non French people :sourire: Option B: we merge maps of France to keep only two. I could for example replace the existing 'France' map with mine, and re-generate the 'France (regions)' map based on mine. - Benefits: same number of France maps as before - Bad side: some people might see this as a change (a good one I think, but still a change) if they use the existing France maps I can do both options. Please let me know which option would be the best for the Apache Superset community. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
