mistercrunch commented on code in PR #29573:
URL: https://github.com/apache/superset/pull/29573#discussion_r1882678294


##########
superset/charts/api.py:
##########
@@ -279,6 +256,53 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
 
     allowed_rel_fields = {"owners", "created_by", "changed_by"}
 
+    @expose("/<id_or_uuid>", methods=["GET"])

Review Comment:
   haven't dug in, but isn't there an existing method that we can modify to now 
support uuid while preserving the API, essentially doing a non-breaking change 
that supports uuid as an input, and adds new uuid fields in the output?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to