nikelborm opened a new pull request, #31460: URL: https://github.com/apache/superset/pull/31460
### SUMMARY Even though `.env-non-dev` is mentioned in `docker/README.md`, it is not mentioned or used anywhere else in the repo, except it's being excluded from the `linkinator` job inside `superset-docs-verify.yml`. The sentence "`docker-compose-non-dev.yml` uses `.env-non-dev` which sets the variable `SUPERSET_ENV` to `production`" is misleading because `docker-compose-non-dev.yml` **doesn't** use `.env-non-dev` and `.env-non-dev` **doesn't** set env var to anything because `.env-non-dev` **doesn't even exist**. Therefore I removed it. ### TESTING INSTRUCTIONS 1. clone repo 2. run `cd superset; grep -rin env-non-dev` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
