mistercrunch commented on PR #31460: URL: https://github.com/apache/superset/pull/31460#issuecomment-2547376391
Right. The idea is that this file is in `.gitgnore` (to prevent people altering/pushing local changes by mistake) and can be used locally to override defaults. Say for instance I could use it to connect to a remove postgres database in my local environment for some reason. It's documented here https://superset.apache.org/docs/installation/docker-compose/#configuring-further so seems fair to remove here as you did in this PR. <img width="1044" alt="Screenshot 2024-12-16 at 6 34 14 PM" src="https://github.com/user-attachments/assets/7b2a562c-a63c-40a2-94ab-91a6b99b3307"; /> It's great to have an easy way to override configs, but in practice I've seen people (me included) getting in a bad state after messing with these files, switching branches, and forgetting they have a "non-standard" environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
