eschutho commented on code in PR #30888:
URL: https://github.com/apache/superset/pull/30888#discussion_r1906104750
##########
superset/dashboards/api.py:
##########
@@ -479,7 +480,10 @@ def get_tabs(self, id_or_slug: str) -> Response:
try:
tabs = DashboardDAO.get_tabs_for_dashboard(id_or_slug)
result = self.tab_schema.dump(tabs)
- return self.response(200, result=result)
+ response_data = json.dumps({"result": result})
+ return Response(
+ response_data, status=HTTPStatus.OK,
mimetype="application/json"
+ )
Review Comment:
@US579 was the self.response not including the correct mimetype? I would
think that all the responses should be json, but maybe @dpgaspar has more info
on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
