US579 commented on code in PR #30888:
URL: https://github.com/apache/superset/pull/30888#discussion_r1938385308
##########
superset/models/dashboard.py:
##########
@@ -338,12 +338,16 @@ def build_tab_tree(
root = get_node("ROOT_ID")
tab_tree: list[dict[str, Any]] = []
all_tabs: dict[str, str] = {}
+ tabs_order: list[str] = []
queue: deque[tuple[dict[str, Any], list[dict[str, Any]]]] = deque()
queue.append((root, tab_tree))
while queue:
node, children = queue.popleft()
build_tab_tree(node, children)
-
+ if (childs := node.get("children")) and node["type"] == "TABS":
+ tabs_order.extend(childs)
+ if tabs_order:
+ all_tabs = {str(t): all_tabs[str(t)] for t in tabs_order}
Review Comment:
ah yep good found!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
