mistercrunch commented on code in PR #31796:
URL: https://github.com/apache/superset/pull/31796#discussion_r1911866207
##########
superset-frontend/cypress-base/cypress/support/e2e.ts:
##########
@@ -26,6 +26,10 @@ require('cy-verify-downloads').addCustomCommand();
// fail on console error, allow config to override individual tests
// these exceptions are a little pile of tech debt
+//
+
+// DISABLING FOR NOW
Review Comment:
Ok so now I know no one has used cypress locally in a while since any
console error/warning including React ones fails the tests. From my
understanding the reason why it works in CI is because the `npm run build`
suppresses these console errors.
I'm thinking we disable for now and re-enable later after cleaning up all
React warnings, which is beyond the scope of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
