mistercrunch commented on PR #31796: URL: https://github.com/apache/superset/pull/31796#issuecomment-2591533447
@sadpandajoe , could use help here around: - understanding how I broke the few tests that are failing here given the content of this PR. I'm not really changing the code/logic in any way, and most tests pass now. What did i change in this PR that could have broken those few tests? or is it just semi-random/flakiness (?) - help fixing the tests, I'm a bit at a loss with Cypress (though I did manage to fix some intricate issues related to timing/flaky tests. It was around an async call that would trigger a react re-render and some race-condition locally, maybe cause my laptop is faster than CI?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
