betodealmeida commented on code in PR #31485:
URL: https://github.com/apache/superset/pull/31485#discussion_r1919056988
##########
superset/common/query_actions.py:
##########
@@ -101,14 +107,28 @@ def _get_full(
datasource = _get_datasource(query_context, query_obj)
result_type = query_obj.result_type or query_context.result_type
payload = query_context.get_df_payload(query_obj,
force_cached=force_cached)
+ presigned_output_location = None
+
+ if datasource.database.backend == "awsathena" and "presto" in
datasource.database.name.lower() \
Review Comment:
We should move this logic to the DB engine specs themselves, to abstract the
feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
