betodealmeida commented on code in PR #31485:
URL: https://github.com/apache/superset/pull/31485#discussion_r1919058648
##########
superset/models/core.py:
##########
@@ -688,6 +691,12 @@ def _log_query(sql: str) -> None:
security_manager,
)
+ if self.db_engine_spec.engine == 'awsathena' and
is_feature_enabled("DOWNLOAD_CSV_FROM_S3") and result_location ==
ChartDataResultLocation.S3:
Review Comment:
This too, should be moved to the DB engine spec so we don't have to
explicitly test for Athena.
Something like:
```python
if self.db_engine_spec.supports_remote_download:
url = self.db_engine_spec.get_remote_download_url(sqls[-1])
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
