korbit-ai[bot] commented on code in PR #31969:
URL: https://github.com/apache/superset/pull/31969#discussion_r1927954423
##########
superset-frontend/src/features/tags/tags.ts:
##########
@@ -194,10 +194,7 @@ export function fetchObjects(
}
export function fetchObjectsByTagIds(
- {
- tagIds = [],
- types,
- }: { tagIds: number[] | undefined; types: string | null },
+ { tagIds = [], types }: { tagIds: number[] | string; types: string | null },
Review Comment:
@hainenber Thank you for pointing that out. It makes sense to maintain the
original structure if other functions are using the same type. However, for
long-term consistency and error reduction, we could consider standardizing the
data types used in API parameters across functions. What do you think about
gradually refactoring other functions to only accept array of numbers for
tagIds as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
