hainenber commented on code in PR #31969:
URL: https://github.com/apache/superset/pull/31969#discussion_r1928002563
##########
superset-frontend/src/features/tags/tags.ts:
##########
@@ -194,10 +194,7 @@ export function fetchObjects(
}
export function fetchObjectsByTagIds(
- {
- tagIds = [],
- types,
- }: { tagIds: number[] | undefined; types: string | null },
+ { tagIds = [], types }: { tagIds: number[] | string; types: string | null },
Review Comment:
Okay, turned out the `fetchObject` function I referred above is not used
anywhere 🤦 . No point in using it to defend keeping old behavior.
Okay, Korbot makes sense here. However, since [`tag?.id` in the old
code](https://github.com/apache/superset/pull/31969/files#diff-1f773753ba66979245b8f1de01db0167a05b1c3b2fbca596cb0cc7d6ae3e8061L155)
will assume undefined value, I'll change the parameter to accommodate the old
behavior as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
