aurokk commented on code in PR #31993:
URL: https://github.com/apache/superset/pull/31993#discussion_r1929949898
##########
superset/db_engine_specs/trino.py:
##########
@@ -62,9 +62,7 @@
class CustomTrinoAuthErrorMeta(type):
def __instancecheck__(cls, instance: object) -> bool:
logger.info("is this being called?")
- return isinstance(
- instance, HttpError
- ) and "error 401: b'Invalid credentials'" in str(instance)
+ return isinstance(instance, HttpError) and "error 401" in str(instance)
Review Comment:
It is overly specific & restrictive. Check for 401 is enough i guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
