korbit-ai[bot] commented on code in PR #31979:
URL: https://github.com/apache/superset/pull/31979#discussion_r1932426515
##########
superset-frontend/src/features/tags/tags.ts:
##########
@@ -197,7 +197,7 @@ export function fetchObjectsByTagIds(
{
tagIds = [],
types,
- }: { tagIds: number[] | undefined; types: string | null },
+ }: { tagIds: (number | undefined)[] | string; types: string | null },
Review Comment:
Hi @hainenber, thanks for your response. I see where you're coming from and
appreciate your reasoning. However, to help ensure that our code is clean and
minimizes potential confusion, could we perhaps consider using explicit types
based on the actual API requirements? For example refactoring our tagIds
parameter to be either all numbers or all strings. This would help eliminate
any risk of the calling function passing in an invalid value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
