betodealmeida opened a new pull request, #32048: URL: https://github.com/apache/superset/pull/32048
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The GSheets database modal has some inconsistencies after OAuth2 was introduced. The current modal asks if the user wants to access "public sheets" or "public and private sheets": <img width="491" alt="Screenshot 2025-01-30 at 11 02 16 AM" src="https://github.com/user-attachments/assets/db39a92a-efa6-4f8c-a3a6-121ee157a13b"; /> If the user selects the latter a new input appears, so the user can provide service account credentials, either by uploading a JSON file or pasting the credentials: <img width="492" alt="Screenshot 2025-01-30 at 11 04 05 AM" src="https://github.com/user-attachments/assets/80962255-6aba-48a0-a91e-535f83372970"; /> With the introduction of OAuth2 (https://github.com/apache/superset/pull/27631) there's now a new way of accessing private sheets. This PR does the following: 1. Remove the "public"/"public and private" dropdown. 2. Informs the user that in order to access private sheets they need to either provide service account credentials or OAuth2 client information. 3. Adds an explicit input for OAuth2 client information (instead of requiring the user to add it to "encrypted extra"). 4. Removes the need for adding at least one "table" (a sheet URL with an associated name). This is how it looks with this PR: <img width="487" alt="Screenshot 2025-01-30 at 11 22 05 AM" src="https://github.com/user-attachments/assets/efc9d138-4d32-4537-a562-cc5ca6c9e06f"; /> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> See above. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
