msyavuz commented on code in PR #31972:
URL: https://github.com/apache/superset/pull/31972#discussion_r1943370755
##########
superset-frontend/src/components/Chart/MenuItemWithTruncation.tsx:
##########
@@ -28,22 +28,25 @@ export type MenuItemWithTruncationProps = {
children: ReactNode;
onClick?: MenuItemProps['onClick'];
style?: CSSProperties;
+ menuKey?: string;
};
export const MenuItemWithTruncation = ({
tooltipText,
children,
- ...props
+ menuKey,
+ ...rest
}: MenuItemWithTruncationProps) => {
const [itemRef, itemIsTruncated] = useCSSTextTruncation<HTMLDivElement>();
return (
<Menu.Item
+ {...rest}
Review Comment:
It actually should stay there, drillby dropdown behaves weirdly when this is
at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
