geido commented on PR #31972: URL: https://github.com/apache/superset/pull/31972#issuecomment-2637637243
A few more comments from manual tests: line-height looks off here: <img width="724" alt="Screenshot 2025-02-05 at 19 38 58" src="https://github.com/user-attachments/assets/7cc9b786-d38d-4d6f-a9a4-0e4f277b65f6"; /> Auto-closing looks inconsistent. For example, it stays open in most cases, when I close the "Save" modal the dropdown also closes, but when I close the "Embed" modal, it won't auto-close. Can we just let it close as soon as you click any of the menu items? <img width="1265" alt="Screenshot 2025-02-05 at 19 44 24" src="https://github.com/user-attachments/assets/1ee91750-bb97-455d-9c3c-346aa0cb6198"; /> I am confused about navigation through keyboard. - When interacting with keyboard on the 3dots menu for the dashboard I can open it with Enter key but then I have to tab into it and it will select some item in the middle instead of the first one. - With the 3dots for charts in a Dashboard instead, I cannot open it with Enter but only with a mouse click, but then it correctly starts with first item and I can then navigate with the keys normally. Can we make sure these dropdowns can open with the Enter key everywhere, are auto-focused and start from the first item for keyboard navigation? I think that should be the expected behavior looking at how a Submenu reacts [here](https://ant.design/components/menu#menu-demo-horizontal) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
