rusackas commented on code in PR #32207:
URL: https://github.com/apache/superset/pull/32207#discussion_r1949464515
##########
superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.test.tsx:
##########
@@ -164,26 +164,43 @@ test('render menu item with submenu without searchbox',
async () => {
expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
});
+// Add global timeout for all tests
+jest.setTimeout(20000);
Review Comment:
Iiiiiinteresting. Then I guess I can pass it in as an extra param on each
test to keep it clean, or just nuke it globally. Not sure if anyone has strong
feelings (I guess I don't).
##########
superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.test.tsx:
##########
@@ -164,26 +164,43 @@ test('render menu item with submenu without searchbox',
async () => {
expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
});
+// Add global timeout for all tests
+jest.setTimeout(20000);
Review Comment:
Iiiiiinteresting. Then I guess I can pass it in as an extra param on each
test to keep it clean, or just bump it globally. Not sure if anyone has strong
feelings (I guess I don't).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
