hainenber commented on code in PR #32235:
URL: https://github.com/apache/superset/pull/32235#discussion_r1952848394
##########
superset/migrations/shared/native_filters.py:
##########
@@ -85,7 +84,7 @@ def convert_filter_scopes_to_native_filters( # pylint:
disable=invalid-name,too
fltr: dict[str, Any] = {
"cascadeParentIds": [],
- "id": f"NATIVE_FILTER-{shortid.generate()}",
+ "id": f"NATIVE_FILTER-{short_id}",
Review Comment:
@korbit-ai apologies, it's my mistake. The pre-loop `shortid` variable
assignment is to initialize ShortId client. You did a good job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
