hainenber commented on code in PR #32235:
URL: https://github.com/apache/superset/pull/32235#discussion_r1952871604


##########
superset/migrations/shared/native_filters.py:
##########
@@ -49,7 +48,7 @@
     :see: convert_filter_scopes
     """
 
-    shortid = ShortId()
+    short_id = f"{shortid()}"[:9]

Review Comment:
   @korbit-ai what if I randomly shuffled the truncated UUIDv4?  Would that 
lower the ID collision chance to acceptable figure?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to