mistercrunch commented on PR #32261: URL: https://github.com/apache/superset/pull/32261#issuecomment-2660371910
@sadpandajoe yes we do in CI, but this add the checks to `pre-commit` so issues can be caught at commit time, which is better. This adds in a fair amount of complexity to deliver on it. Wondering if it would make sense to only do it on superset-frontend/**/js-and-ts-files to keep pre-commit.yml a bit simpler. @alveifbklsiu259 is it all super fast? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
