mistercrunch commented on code in PR #32261:
URL: https://github.com/apache/superset/pull/32261#discussion_r1956781019
##########
.pre-commit-config.yaml:
##########
@@ -68,6 +68,39 @@ repos:
language: system
pass_filenames: true
files: \.(js|jsx|ts|tsx)$
+ - repo: local
+ hooks:
+ - id: type-checking-frontend
+ name: Type-Checking (Frontend)
+ entry: ./scripts/check-type.js
Review Comment:
From my understanding this will check all the files, not just the ones
touched in the commit is that right? Same for all other entries.
If so it seems this will greatly slow down commit speed.
You can see how I did it for eslint, but by using `$@`, I'm able to pass the
list of files to check to the command, so it will only check the files touched
in that specific commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
