michael-s-molina commented on code in PR #32358:
URL: https://github.com/apache/superset/pull/32358#discussion_r1971412748
##########
superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx:
##########
@@ -224,6 +225,31 @@ const config: ControlPanelConfig = {
['y_axis_format'],
['x_axis_time_format'],
['currency_format'],
+ [<ControlSubSectionHeader>Border</ControlSubSectionHeader>],
+ [
+ {
+ name: 'element_border',
+ config: {
+ type: 'ColorPickerControl',
+ label: t('Border Color'),
+ renderTrigger: true,
+ description: t('Select border color for Heatmap elements'),
+ default: { r: 255, g: 255, b: 255, a: 1 },
+ },
+ },
+ ],
+ [
+ {
+ name: 'enable_border',
Review Comment:
If the border color can be transparent by default, you don't need a checkbox
to enable the border, you just need to set a color. You could also have a
control for border width with a default value of 0 indicating no border.
##########
superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx:
##########
@@ -224,6 +225,31 @@ const config: ControlPanelConfig = {
['y_axis_format'],
['x_axis_time_format'],
['currency_format'],
+ [<ControlSubSectionHeader>Border</ControlSubSectionHeader>],
+ [
+ {
+ name: 'element_border',
+ config: {
+ type: 'ColorPickerControl',
+ label: t('Border Color'),
+ renderTrigger: true,
+ description: t('Select border color for Heatmap elements'),
+ default: { r: 255, g: 255, b: 255, a: 1 },
+ },
+ },
+ ],
+ [
+ {
+ name: 'enable_border',
Review Comment:
If the border color can be transparent by default, you don't need a checkbox
to enable the border, you just need to set a color. You could also have a
control for border width with a default value of 0 indicating no border.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
