Dev10-34 commented on code in PR #32358:
URL: https://github.com/apache/superset/pull/32358#discussion_r1972053729
##########
superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx:
##########
@@ -224,6 +225,31 @@ const config: ControlPanelConfig = {
['y_axis_format'],
['x_axis_time_format'],
['currency_format'],
+ [<ControlSubSectionHeader>Border</ControlSubSectionHeader>],
+ [
+ {
+ name: 'element_border',
+ config: {
+ type: 'ColorPickerControl',
+ label: t('Border Color'),
+ renderTrigger: true,
+ description: t('Select border color for Heatmap elements'),
+ default: { r: 255, g: 255, b: 255, a: 1 },
+ },
+ },
+ ],
+ [
+ {
+ name: 'enable_border',
Review Comment:
Thank you for being so patient and helpful! I have added the changes as you
mentioned. Earlier I didn't realize how to exactly use the addAlpha() function
that was defined. I was creating a separate variable for opacity and passing
that through the function which ended up not letting it function it properly.
Passing elementBorder.a as the second argument was the way to go.
I removed the function from ui-core packages along with the enable border
checkbox.
Added a slider control for border width as that looked nice. However, I set
its default width to 1 as the effects should be visible upon increasing the
opacity immediately and the user wouldn't need to work with 2 controls for
their effect to show.
I have a suggestion as well. Instead of having the opacity set to 0
(transparent), I keep the opacity to max, but keep the border width to 0. My
reasoning is that for someone who doesn't really care for how the borders look,
such a user will need to tweak just 1 visible control for them to be able to
visualize their needs properly. Someone who is looking to customize and style
their charts can use all the controls as needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
