EnxDev commented on code in PR #32112:
URL: https://github.com/apache/superset/pull/32112#discussion_r1971517690
##########
superset-frontend/src/components/Icons/AntdEnhanced.tsx:
##########
@@ -128,26 +175,45 @@ const AntdIcons = {
SaveOutlined,
SearchOutlined,
SettingOutlined,
+ StarOutlined,
+ StarFilled,
StopOutlined,
SyncOutlined,
+ TagOutlined,
TagsOutlined,
+ TableOutlined,
+ LockOutlined,
+ UploadOutlined,
UnlockOutlined,
UpOutlined,
UserOutlined,
+ VerticalAlignBottomOutlined,
+ VerticalAlignTopOutlined,
VerticalLeftOutlined,
VerticalRightOutlined,
+ NumberOutlined,
+ ThunderboltOutlined,
+ FilterOutlined,
+ UnorderedListOutlined,
+ WarningOutlined,
};
const AntdEnhancedIcons = Object.keys(AntdIcons)
.filter(k => !k.includes('TwoTone'))
.map(k => ({
[k]: (props: IconType) => {
const whatRole = props?.onClick ? 'button' : 'img';
- // @ts-ignore TODO(hainenber): fix the type compatiblity between
- // StyledIcon component prop and AntdIcon values
- return <StyledIcon component={AntdIcons[k]} role={whatRole} {...props}
/>;
+ const ariaLabel = props['aria-label'] || k;
+ return (
+ <StyledIcon
+ // @ts-ignore
+ component={AntdIcons[k as keyof typeof AntdIcons]}
Review Comment:
For now is wip, I'll try to remove @ts-ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
