msyavuz commented on code in PR #32112:
URL: https://github.com/apache/superset/pull/32112#discussion_r1971512163
##########
superset-frontend/src/features/charts/ChartCard.tsx:
##########
@@ -68,10 +68,39 @@ export default function ChartCard({
const canEdit = hasPerm('can_write');
const canDelete = hasPerm('can_write');
const canExport = hasPerm('can_export');
- const theme = useTheme();
-
const menu = (
<Menu>
+ {canEdit && (
+ <Menu.Item>
+ <div
+ data-test="chart-list-edit-option"
+ role="button"
+ tabIndex={0}
+ onClick={() => openChartEditModal(chart)}
+ >
+ <Icons.EditOutlined
+ iconSize="l"
+ css={{ verticalAlign: 'baseline' }}
+ />{' '}
+ {t('Edit')}
+ </div>
+ </Menu.Item>
+ )}
+ {canExport && (
+ <Menu.Item>
+ <div
+ role="button"
+ tabIndex={0}
+ onClick={() => handleBulkChartExport([chart])}
+ >
+ <Icons.UploadOutlined
+ iconSize="l"
+ css={{ verticalAlign: 'baseline' }}
+ />{' '}
+ {t('Export')}
+ </div>
+ </Menu.Item>
+ )}
Review Comment:
Is this order change intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
