betodealmeida commented on code in PR #32485:
URL: https://github.com/apache/superset/pull/32485#discussion_r1978043389
##########
superset/db_engine_specs/base.py:
##########
@@ -1792,6 +1788,38 @@ def estimate_query_cost( # pylint:
disable=too-many-arguments
]
@classmethod
+ def impersonate_user(
+ cls,
+ database: Database,
+ username: str | None,
+ user_token: str | None,
+ url: URL,
+ engine_kwargs: dict[str, Any],
+ ) -> tuple[URL, dict[str, Any]]:
+ """
+ Modify URL and/or engine kwargs to impersonate a different user.
+ """
+ # Update URL using old methods until 6.0.0.
+ url = cls.get_url_for_impersonation(url, True, username, user_token)
+
+ # Update engine kwargs using old methods. Note that #30674 modified
the method
+ # signature, so we need to check if the method has the old signature.
+ connect_args = engine_kwargs.setdefault("connect_args", {})
+ args = [
+ connect_args,
+ url,
+ username,
+ user_token,
+ ]
+ if "database" in signature(cls.update_impersonation_config).parameters:
+ args.insert(0, database)
+
+ cls.update_impersonation_config(*args)
Review Comment:
This is technically true, but we know that there are only 2 possible
signatures, so it's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
