villebro commented on code in PR #32506:
URL: https://github.com/apache/superset/pull/32506#discussion_r1980506177
##########
superset/db_engine_specs/postgres.py:
##########
@@ -411,7 +411,9 @@ def get_table_names(
)
@staticmethod
- def get_extra_params(database: Database) -> dict[str, Any]:
+ def get_extra_params(
+ database: Database, source: QuerySource | None = None
+ ) -> dict[str, Any]:
Review Comment:
@korbit-ai I don't necessarily agree. `BaseEngineSpec` provides the abstract
foundations that are used by all database implementations. It goes without
saying that parameters in a specific method may be needed on only a subset of
databases, and as such, will be redundant in others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
