korbit-ai[bot] commented on code in PR #32506:
URL: https://github.com/apache/superset/pull/32506#discussion_r1982198565
##########
superset/db_engine_specs/base.py:
##########
@@ -2019,12 +2015,15 @@ def mutate_db_for_connection_test( # pylint:
disable=unused-argument
return None
@staticmethod
- def get_extra_params(database: Database) -> dict[str, Any]:
+ def get_extra_params(
+ database: Database, source: QuerySource | None = None
+ ) -> dict[str, Any]:
Review Comment:
### Vague Parameter Name <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The method uses a vague name 'extra_params' without specifying what these
parameters are for.
###### Why this matters
Vague parameter names make it difficult to understand the purpose and
contents of the returned dictionary without diving into implementation details.
###### Suggested change ∙ *Feature Preview*
Rename the method to be more specific:
```python
def get_connection_params(
database: Database, source: QuerySource | None = None
) -> dict[str, Any]:
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/3375bb54-0852-4ddd-80c9-d95e8b9f0944?suggestedFixEnabled=true)
💬 Chat with Korbit by mentioning @korbit-ai.
</sub>
<!--- korbi internal id:3db14355-f454-4ed7-b953-2bb33080a6cc -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
