Vitor-Avila commented on code in PR #32336:
URL: https://github.com/apache/superset/pull/32336#discussion_r1982607943
##########
superset/commands/report/execute.py:
##########
@@ -571,10 +586,13 @@ def _send(
recipient.type = ReportRecipientType.SLACKV2
notification = create_notification(recipient,
notification_content)
notification.send()
- except (UpdateFailedError, NotificationParamException) as err:
- # log the error but keep processing the report with SlackV1
- logger.warning(
- "Failed to update slack recipients to v2: %s", str(err)
+ except (UpdateFailedError, NotificationParamException) as
mig_err:
Review Comment:
This is actually inside an except block that's parallel to 597. But I can
move that line to an "outer" try/except and have this specific except nested
and I think that would remove this duplicated syntax. I'll try that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
