Vitor-Avila commented on code in PR #32336:
URL: https://github.com/apache/superset/pull/32336#discussion_r1983152654
##########
superset/reports/api.py:
##########
@@ -574,7 +574,7 @@ def slack_channels(self, **kwargs: Any) -> Response:
"""
try:
params = kwargs.get("rison", {})
- search_string = params.get("search_string")
+ search_string = [params.get("search_string", "").strip()]
Review Comment:
Ohh, I know why I moved this outside. It's because during the v1 -> v2
migration, I need to know the list length before calling
`get_channels_with_search` to confirm if all channels were found. Doing it
outside and then again in the method felt repetitive, but considering this is
specific to the migration, and this code will be removed soon as only V2 is
going to be supported going forward I think that's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
