justinpark opened a new pull request, #32549:
URL: https://github.com/apache/superset/pull/32549

   ### SUMMARY
   
   When the dataset values of the native filter include bigint values, an error 
occurs in the filter selection rendering.
   This happens because the value is converted to a BigNumber class implemented 
by json-bigint and passed as a React child. To resolve this issue, this commit 
enables an option to convert the values to native int(`useNativeBigInt`), which 
allows them to be passed as compatible bigint to the children, thus solving the 
problem.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   ![Screenshot 2025-03-07 at 2 20 49 
PM](https://github.com/user-attachments/assets/71a09d6e-618b-4d40-b45a-a57ce70474d6)
   
   After:
   
   ![Screenshot 2025-03-07 at 4 58 54 
PM](https://github.com/user-attachments/assets/efbd6941-eb4b-4e11-9bed-8d690bbe5a3d)
   
   ### TESTING INSTRUCTIONS
   
   Create a dataset from the following SQL
   ```
   select 1234567890123456789 as bigIntVal
   ```
   Choose the dataset in the filter, and then select the input box to check if 
the option is rendered correctly
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to