korbit-ai[bot] commented on code in PR #32549:
URL: https://github.com/apache/superset/pull/32549#discussion_r1985905978
##########
superset-frontend/packages/superset-ui-core/src/time-format/formatters/finestTemporalGrain.ts:
##########
@@ -48,26 +48,30 @@ export default function finestTemporalGrain(
} = useLocalTime ? localTimeUtils : utcUtils;
let formatFunc = formatYear;
- values.forEach((value: any) => {
- if (formatFunc === formatYear && isNotFirstMonth(value)) {
- formatFunc = formatMonth;
- }
- if (formatFunc === formatMonth && isNotFirstDayOfMonth(value)) {
- formatFunc = formatDay;
- }
- if (formatFunc === formatDay && hasHour(value)) {
- formatFunc = formatHour;
- }
- if (formatFunc === formatHour && hasMinute(value)) {
- formatFunc = formatMinute;
- }
- if (formatFunc === formatMinute && hasSecond(value)) {
- formatFunc = formatSecond;
- }
- if (formatFunc === formatSecond && hasMillisecond(value)) {
- formatFunc = formatMillisecond;
- }
- });
+ try {
+ values.forEach((value: any) => {
+ if (formatFunc === formatYear && isNotFirstMonth(value)) {
+ formatFunc = formatMonth;
+ }
+ if (formatFunc === formatMonth && isNotFirstDayOfMonth(value)) {
+ formatFunc = formatDay;
+ }
+ if (formatFunc === formatDay && hasHour(value)) {
+ formatFunc = formatHour;
+ }
+ if (formatFunc === formatHour && hasMinute(value)) {
+ formatFunc = formatMinute;
+ }
+ if (formatFunc === formatMinute && hasSecond(value)) {
+ formatFunc = formatSecond;
+ }
+ if (formatFunc === formatSecond && hasMillisecond(value)) {
+ formatFunc = formatMillisecond;
+ }
+ });
+ } catch (e) {
+ // ignore
+ }
Review Comment:
### Silent Error Swallowing in Critical Format Detection <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
Silent error handling in the datetime format detection logic could mask
important issues and lead to unexpected formatting behavior.
###### Why this matters
If there's an error during format detection, the code will silently continue
with potentially incorrect formatting, which could lead to data
misrepresentation without any indication of the failure.
###### Suggested change ∙ *Feature Preview*
Implement proper error handling to maintain the default format and log the
error for debugging:
```typescript
catch (e) {
console.warn('Error detecting temporal grain:', e);
formatFunc = formatYear; // Ensure we maintain the default format
}
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9ed90830-89ea-4cd3-b70f-51cb8c45b65a?suggestedFixEnabled=true)
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:f6c6c7f8-5286-4a81-8376-314b8dccbc20 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
