rusackas commented on PR #32596: URL: https://github.com/apache/superset/pull/32596#issuecomment-2718149709
> @rusackas this works for me, but is largely a rollback of https://github.com/apache/superset/pull/32352 in some key areas. Wondering what's wrong here. Fine by me! It seems to just roll back the parts I wasn't really hoping to touch much in the first place :D The things I set out to do which still seem to be in effect here are: • Run `eslint` with the ` --quiet` flag • Set up/ensure Node 20 • Bump `mypy` to 1.15.0 With this change, we lose two things, which maybe we can fix here or in subsequent PR(s): • Reverts typescript checking (which led to 95% of my last PR's contents). I'm sure we can add a new hook for that. It was catching these since `npm run type` slides in as a side-run task of `npm run lint` :) • `Prettier` is currently fixing busted files when running the hooks locally, but `eslint` no longer is. I wonder if we should always run with the `--fix` flag, or if that needs to be somehow dynamically disabled on CI and only run locally ¯\\\_(ツ)_/¯ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
