mistercrunch commented on PR #32596:
URL: https://github.com/apache/superset/pull/32596#issuecomment-2718544380

   > Reverts typescript checking
   
   From my understanding it's still here -> 
https://github.com/apache/superset/pull/32596/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9R77-R83
   
   > Prettier is currently fixing busted files when running the hooks locally, 
but eslint no longer is
   
   Can add `--fix` in there, super easy. It's probably better that way. 
Personally before I would run a custom command to try and do it, but it's 
probably a better behavior to always `--fix`, let me add it to the PR here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to