betodealmeida commented on code in PR #32702:
URL: https://github.com/apache/superset/pull/32702#discussion_r1999309405
##########
superset/databases/api.py:
##########
@@ -776,18 +776,38 @@ def schemas(self, pk: int, **kwargs: Any) ->
FlaskResponse:
if not database:
return self.response_404()
try:
- catalog = kwargs["rison"].get("catalog")
+ params = kwargs["rison"]
+ catalog = params.get("catalog")
schemas = database.get_all_schema_names(
catalog=catalog,
cache=database.schema_cache_enabled,
cache_timeout=database.schema_cache_timeout or None,
- force=kwargs["rison"].get("force", False),
+ force=params.get("force", False),
)
schemas = security_manager.get_schemas_accessible_by_user(
database,
catalog,
schemas,
)
+ if params.get("upload_allowed"):
+ if not database.allow_file_upload:
+ return self.response(
+ 400,
+ message="File upload is disabled on this database
connection",
+ )
Review Comment:
I think we could just return an empty list in this case, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
