Vitor-Avila commented on PR #32702:
URL: https://github.com/apache/superset/pull/32702#issuecomment-2740727436

   Hey @michael-s-molina!
   Oh I didn't see that -- yes, it should fix that ticket, with the exception 
of this part:
   
   > Another important thing is make the Schema input required if only certain 
schemas are allowed.
   
   Not sure if you want to keep it open for this second part. Is there a 
scenario where we don't want the schema required (and which should be used in 
that case)?
   
   One last thing: I noticed that if you try editing the allowed schemas field, 
typing a `,` does not show up. I think there's some logic in the frontend to 
convert the info from the API payload `["foo", "bar"]` to `foo, bar` and this 
logic is not being executed only when the dialog opens, but on every change. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to