mistercrunch commented on PR #32770: URL: https://github.com/apache/superset/pull/32770#issuecomment-2744148660
Looking solid. Some thoughts: - based on your usage with JSON serialization, you may want to sort the roles to have a more deterministic output. It looked like you were doing potentially equality `==` operations on it, and the role sort order may change randomly. Not required for the PR, but just raising given your usage. - would be great to have a similar function to get or check user specific perms, but probably also out of scope for this PR. Idea is someone could check if a user has access to a given table, structure or just about anything handled through perms. Note that the list of perms can get very large (hundreds), `current_user_check_perm(perm)` might be useful for folks out there doing more advanced things with jinja. Tagging @Vitor-Avila since he's been a jinja wizard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
