Vitor-Avila commented on PR #32770:
URL: https://github.com/apache/superset/pull/32770#issuecomment-2749033284
This looks really great! (btw TIL about the `|tojson` filter -- that's
likely helpful for the `filter_values` macro too).
I totally agree there's value in having both options. We also have the
`|where_in` filter that could make this into `('Admin', 'Public', 'Alpha')` if
someone needs to use this in a SQL statement, for example. Not sure if you want
to add this to the docs too.
I think it might be interesting to sort the roles specially before using
them as a cache key, to avoid un-necessary hits to the DB just because of
sorting changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
