mistercrunch commented on PR #32850: URL: https://github.com/apache/superset/pull/32850#issuecomment-2752332880
Looked up the [lib](https://www.npmjs.com/package/natural-compare-lite?activeTab=code) and it's like 50 LoC, wondering if we should just copy/paste the code as opposed to bringing it the lib... What's our take on micropackages like this one. Maybe @rusackas has a take on it. Otherwise LGTM. Lib is very small/simple, and hasn't changed in 9 years :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
