fhyy opened a new pull request, #32857: URL: https://github.com/apache/superset/pull/32857
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Drill aliases with the same name as the source column makes queries ambiguous and cannot group the column properly. A suffix is added on Drill labels to avoid this collision, as per discussion in a previous PR #29455. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before:   After:   ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> * Start Superset * Navigate to the Superset web application and login * Connect to a Drill database * Create a dataset of the Drill database * Create a chart from that dataset * Select visualization type Table with query mode Aggregate * Add a column in the dimensions * Aggregate the data of the columns (e.g. length(column_a)) * Press "view query" * The query should now contain a GROUP BY statement of an aggregation, and the alias of that aggregation should have a MD5-based suffix at the end of the name. Example: ``` SELECT length(n_name) AS n_name_ebba65 ... GROUP BY length(n_name) ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ x ] Has associated issue: #28443 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
