fhyy commented on PR #32857: URL: https://github.com/apache/superset/pull/32857#issuecomment-2754933607
Understandable, I just couldn't run the master version with our setup and couldn't spend more time debugging that issue, so I had no way of testing it except on 4.1 where I could confirm this to still be an issue. I based the solution on the discussion in #29455 to use `_mutate_label` and saw that other engine specs did it this way (see [databend](https://github.com/apache/superset/blob/f1e0c9c8ed1044eddd91d95da9f08b04703f1fea/superset/db_engine_specs/databend.py#L366) and [clickhouse](https://github.com/apache/superset/blob/f1e0c9c8ed1044eddd91d95da9f08b04703f1fea/superset/db_engine_specs/clickhouse.py#L402)). MD5 is most likely to not cause collisions with other fields though, say if a database has columns `tool` and `tool_drill` :sweat_smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
