alexandrusoare commented on code in PR #32845:
URL: https://github.com/apache/superset/pull/32845#discussion_r2022665843
##########
superset-frontend/src/components/DropdownContainer/index.tsx:
##########
@@ -364,9 +364,11 @@ const DropdownContainer = forwardRef(
/>
<Popover
- overlayInnerStyle={{
- maxHeight: `${MAX_HEIGHT}px`,
- overflow: showOverflow ? 'auto' : 'visible',
+ styles={{
+ body: {
+ maxHeight: `${MAX_HEIGHT}px`,
+ overflow: showOverflow ? 'auto' : 'visible',
+ },
}}
Review Comment:
overlayInnerStyle is deprecated right?
##########
superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigItem.tsx:
##########
@@ -47,8 +47,8 @@ export default memo(function ColumnConfigItem({
)}
trigger="click"
placement="right"
- overlayInnerStyle={{ width, height }}
- overlayClassName="column-config-popover"
+ styles={{ body: { width, height } }}
+ rootClassName="column-config-popover"
>
Review Comment:
Here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
