msyavuz commented on code in PR #32845:
URL: https://github.com/apache/superset/pull/32845#discussion_r2022755837
##########
superset-frontend/src/components/Menu/index.tsx:
##########
@@ -86,25 +86,31 @@ const StyledNav = styled(AntdMenu)`
align-items: center;
height: 100%;
gap: 0;
+ border-bottom: 0;
+ line-height: ${theme.lineHeight};
&.antd5-menu-horizontal > .antd5-menu-item {
height: 100%;
display: flex;
align-items: center;
margin: 0;
- border-bottom: 2px solid transparent;
padding: ${theme.sizeUnit * 2}px ${theme.sizeUnit * 4}px;
- &:hover {
- background-color: ${theme.colors.primary.light5};
- border-bottom: 2px solid transparent;
- & a:after {
- opacity: 1;
- width: 100%;
- }
+ ::after {
+ content: '';
+ position: absolute;
+ width: 100%;
+ height: 2px;
+ background-color: ${theme.colors.primary.base};
+ bottom: ${theme.sizeUnit / 4}px;
+ left: 0;
+ transform: scale(0);
+ transition: 0.2s all ease-out;
Review Comment:
I provided some screenshots. These styles are here to simplify the hover
effects of MainNav.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
