kgabryje commented on PR #30134: URL: https://github.com/apache/superset/pull/30134#issuecomment-2783693455
@martyngigg @mistercrunch I fixed the Cypress tests and moved external navigations to a util function to centralize the usage of `ensureAppRoot`. There are still a few places where we use `ensureAppRoot` which I couldn't replace - for example some antd components take a relative path, but they resolve it with the origin and it's not possible to configure the base url. I suppose putting `<base>` tag in the head could solve this problem. However, this would block us from using a different base url for static assets -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
