martyngigg commented on PR #30134: URL: https://github.com/apache/superset/pull/30134#issuecomment-2786375803
> @martyngigg @mistercrunch I fixed the Cypress tests (pretty ugly solution but I had to add wildcards to all `cy.intercept` statements - apparently it ignores baseUrl) and moved external navigations to a util function to centralize the usage of `ensureAppRoot`. There are still a few places where we use `ensureAppRoot` which I couldn't replace - for example some antd components take a relative path, but they resolve it with the origin and it's not possible to configure the base url. I suppose putting `<base>` tag in the head could solve this problem. However, this would block us from using a different base url for static assets @kgabryje Thank you so much for looking at this and figuring out the issues with the tests that I couldn't work out. I don't really have any experience with antd but I've noticed quite a few comments like "// TODO: Remove antd" across various components - is there a long term plan to remove it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
